Pull to Refresh
Hi guys,
Great job with AndTweet.
If ever you guys want a Pull to Refresh features, I've added code from here https://github.com/johannilsson/android-pulltorefresh to your App.
I've put in on my github repo:
https://github.com/ddominator/AndTweet
Sorry if it's in git and on github. Anyways it works but I think there should be some adjustments/tweaking to be made. I'm a Java newbie.
5 comments
-
Adminyvolk
(Admin, AndTweet)
commented
Thank you, ddominator, for your idea of "Pull To Refresh" and for explanations. We will be glad to see you as a contributor of AndTweet project!
I added class instance variable: 'private Context mContext;', removed couple of '@Override'-s that produced compile errors and I could compile and see the app running :-)
I like the idea of refreshing when you scroll up to the _top_ of the list: it complements "Loading..." of the next page of (old) tweets, when you scroll _down_ - the feature that is already implemented in AndTweet.
Current implementation, though, is not ready for inserting into main AndTweet code, IMHO:
- it duplicates existing code from '/src/com/xorcode/andtweet/TweetListActivity.java' (it should use it… with a help of some callback…);
- it executes synchronously (it should call somehow what is now ‘com.xorcode.andtweet.TweetListActivity.manualReload()’ and receive asynchronous notification back). -
AdminTorgny Bjers
(Admin, AndTweet)
commented
As long as the source code that Johan Nilsson posted and it's compatible with the GNU license, I think we'll be able to use it.
-
Rex Justin Lim
commented
Hi all.
I'm posting this after I read all the comments on my github (sorry for my bad coding).
This is my compiled APK: http://www.mediafire.com/?x6ywms7mvbft91x (sorry I have not yet configured dropbox for public file sharing)
It uses AndTweet for iDroid OAuth. I'm using it on Gingerbread 2.3.2 and I didn't see any problems (I added an Android.mk to make it compile when I compile my Gingebread builds).
The Pull to Refresh feature is a little sluggish but it works. I think some tweaks are needed to make it like the PullToRefresh on the real Twitter Apps.
PS. I haven't asked permission from Johan Nilsson, the author of Pull to Refresh (link in first post).
-
Adminyvolk
(Admin, AndTweet)
commented
Hi Rex Justin Lim,
I've already compared repositories to figure out what you did :-) - Thank you, I even see a couple of fixes in the old code!
It would be good and quicker for everybody if you could publish ready to test package?!BTW I found some problems with AndTweet 1.0.5 in Gingerbread (I've got it last week on my Nexus One), so creating some Gingerbread-specific code for AndTweet is inevitable...
-
AdminTorgny Bjers
(Admin, AndTweet)
commented
Great idea, we'll take a look at it!